This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix issues with default object params in async functions #96
Conversation
danez
force-pushed the
danez:dafault-params-92
branch
from
704dc5b
to
3d502a8
Aug 18, 2016
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Aug 18, 2016
•
Current coverage is 96.91% (diff: 100%)
|
danez
added
the
Tag: Bug Fix
label
Aug 19, 2016
danez
force-pushed the
danez:dafault-params-92
branch
from
3d502a8
to
2c68435
Aug 23, 2016
hzoo
merged commit 2cfae60
into
babel:master
Aug 23, 2016
1 check was pending
continuous-integration/travis-ci/pr
The Travis CI build is in progress
Details
danez
deleted the
danez:dafault-params-92
branch
Aug 31, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
danez commentedAug 18, 2016
•
edited
This fixes the other half of #92
It was throwing an error because shorthands were not allowed in this scenario, by setting the correct params for parseExprListItem() when it is an async function fixes the problem.
Fix #92