This repository has been archived by the owner. It is now read-only.

Remove exponentiationOperator, asyncFunctions, trailingFunctionCommas #98

Merged
merged 4 commits into from Aug 23, 2016

Conversation

Projects
None yet
3 participants
@danez
Copy link
Member

danez commented Aug 19, 2016

This enables them by default now.

Also restructure the test directories, with es2015, es2016, es2017 names ....

I checked that the number of tests stayed the same.

Daniel Tschinder

@danez danez added the spec-update label Aug 19, 2016

Daniel Tschinder
@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Aug 19, 2016

can do the same for trailingFunctionCommas, dono if you want that in a separate one

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Aug 19, 2016

we should deprecate classConstructorCall too

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 19, 2016

Current coverage is 96.91% (diff: 100%)

Merging #98 into master will decrease coverage by <.01%

@@             master        #98   diff @@
==========================================
  Files            19         19          
  Lines          2922       2919     -3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           2832       2829     -3   
  Misses           90         90          
  Partials          0          0          

Powered by Codecov. Last update b649671...1349baa

@danez

This comment has been minimized.

Copy link
Member Author

danez commented Aug 19, 2016

I also started restructuring and renaming the test dirs
at first i wanted to do something like

--es
  -- 2015
  -- 2016

but babel-helper-fixtures is limited to how deep one can nest dirs, so I did this now:

-- es2015
-- es2016

Gonna do all in this PR.

@danez danez changed the title Remove the exponentiationOperator-plugin as it is now in es2016 Remove exponentiationOperator, asyncFunctions, trailingFunctionCommas Aug 19, 2016

Daniel Tschinder added some commits Aug 19, 2016

Daniel Tschinder
Daniel Tschinder
@danez

This comment has been minimized.

Copy link
Member Author

danez commented Aug 19, 2016

I'm not sure how to proceed with classConstructorCall probably we can just remove it with the next major. Should we log a warning if it is used already?

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Aug 19, 2016

Yeah we would remove it in the next major - just not sure given we would need to update babel too. You can just leave it for now.

I updated the docs a while ago (http://babeljs.io/docs/plugins/transform-class-constructor-call/) but not sure who looks at it

@hzoo hzoo merged commit 4506822 into babel:master Aug 23, 2016

3 checks passed

codecov/patch 100% of diff hit (target 96.91%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.08% compared to b649671
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danez danez deleted the danez:remove-exponentiation-operator-plugin branch Aug 23, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.