Merge pull request #194 from simonkotwicz/sk/dev

Fix babel/semi for private properties
babel · Jun 29, 2020 · db19a0a · db19a0a
2 parents 0f558b3 + 7c96021
commit db19a0a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/rules/semi.js b/rules/semi.js
@@ -70,7 +70,7 @@ const report = (context, node, missing) => {
 const semiRuleWithClassProperty = ruleComposer.joinReports([
     semiRule,
     context => ({
-        ClassProperty(node) {
+        "ClassProperty, ClassPrivateProperty"(node) {
             const options = context.options[1];
             const exceptOneLine = options && options.omitLastInOneLineBlock === true;
 

diff --git a/tests/rules/semi.js b/tests/rules/semi.js
@@ -101,12 +101,14 @@ ruleTester.run("semi", rule, {
 
         // babel
         "class Foo { bar = 'example'; }",
+        "class Foo { #bar = 'example'; }",
         "class Foo { static bar = 'example'; }",
         { code: "async function foo() { for await (let thing of {}) { console.log(thing); } }", parserOptions: { ecmaVersion: 6 } },
         { code: "class Foo { bar = () => {}; }", options: ["always", { omitLastInOneLineBlock: true }] },
 
         // babel, "never"
         { code: "class Foo { bar = 'example' }", options: ["never"] },
+        { code: "class Foo { #bar = 'example' }", options: ["never"] },
         { code: "class Foo { static bar = 'example' }", options: ["never"] },
         { code: "class Foo { bar = () => {} }", options: ["never"] },
     ],
@@ -185,6 +187,7 @@ ruleTester.run("semi", rule, {
 
         // babel
         { code: "class Foo { bar = 'example' }", errors: [{ message: "Missing semicolon." }] },
+        { code: "class Foo { #bar = 'example' }", errors: [{ message: "Missing semicolon." }] },
         { code: "class Foo { static bar = 'example' }", errors: [{ message: "Missing semicolon." }] },
         {
             code: "class Foo { bar = () => {} }",
@@ -194,6 +197,7 @@ ruleTester.run("semi", rule, {
 
         // babel, "never"
         { code: "class Foo { bar = 'example'; }", options: ["never"], errors: [{ message: "Extra semicolon." }] },
+        { code: "class Foo { #bar = 'example'; }", options: ["never"], errors: [{ message: "Extra semicolon." }] },
         { code: "class Foo { static bar = 'example'; }", options: ["never"], errors: [{ message: "Extra semicolon." }] },
         {
             code: "class Foo { bar = () => {}; }",