Skip to content
This repository has been archived by the owner on Aug 4, 2020. It is now read-only.

Added babel/no-invalid-this #101

Merged
merged 2 commits into from
Nov 2, 2016
Merged

Conversation

mathieumg
Copy link
Contributor

@mathieumg mathieumg commented Oct 3, 2016

This is to help closes #12. The implementation is really rudimentary, whenever inside a class property it considers all this to be valid. I tried to think about it a bit, is there any scenario where it isn't the case?

All files are taken from ESLint since this proposal is still only stage 2, but might make its way into ESLint if it ever reaches stage 4 (hopefully!):

Build fails on 0.10 and 0.12 because of #71 (comment)

I also added the lodash.clonedeep module to the dev dependencies since it was used in the original tests. Let me know if there is anything.

@mathieumg mathieumg force-pushed the no-invalid-this branch 2 times, most recently from 7ef39f4 to b93c1cd Compare October 3, 2016 20:25
@mathieumg
Copy link
Contributor Author

@jquense @hzoo

@jquense
Copy link
Contributor

jquense commented Oct 26, 2016

can you adjust to pass CI?

@mathieumg
Copy link
Contributor Author

You mean remove 0.10 and 0.12 from the CI? See #71 (comment)

@mathieumg
Copy link
Contributor Author

@jquense ping

0.10 now out of maintenance and 0.12 to follow very soon, too.

@jquense jquense merged commit 026eab8 into babel:master Nov 2, 2016
@mathieumg mathieumg deleted the no-invalid-this branch November 2, 2016 18:47
@mathieumg
Copy link
Contributor Author

Thanks! I imagine dropping 0.10/0.12 support will be done separately?

@FL0RIANMEYER

This comment has been minimized.

@ljharb

This comment has been minimized.

@FL0RIANMEYER

This comment has been minimized.

nicolo-ribaudo pushed a commit to babel/babel that referenced this pull request Nov 14, 2019
…valid-this

Added `babel/no-invalid-this`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-invalid-this with ES7 class properties
4 participants