Skip to content
This repository has been archived by the owner on Aug 4, 2020. It is now read-only.

Deprecate rule no-await-in-loop #123

Merged
merged 2 commits into from Mar 4, 2017
Merged

Deprecate rule no-await-in-loop #123

merged 2 commits into from Mar 4, 2017

Conversation

daltones
Copy link
Contributor

@daltones daltones commented Mar 4, 2017

Fixes #116

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jquense jquense merged commit 6f2faae into babel:master Mar 4, 2017
@hzoo
Copy link
Member

hzoo commented Mar 6, 2017

If you want to be a collab @daltones let me know!

aside: also I recommend making a branch instead of changing your master branch

@kentcdodds
Copy link
Member

@daltones, this might also be helpful: makeapullrequest.com

@daltones
Copy link
Contributor Author

daltones commented Mar 7, 2017

@hzoo I'm still getting familiar with ESLlint code base and plugins. I'll try to continue contributing whenever I have time. 😺

Oh, my fault… I normally do that, this time I forgot the PR specific branch.

@kentcdodds Thanks for the tip!

nicolo-ribaudo pushed a commit to babel/babel that referenced this pull request Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants