This repository has been archived by the owner on Aug 4, 2020. It is now read-only.
Refactor rules to use eslint-rule-composer #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existentialism
force-pushed
the
composer
branch
from
9301fc1
to
3113581
Compare
hzoo
approved these changes
Mar 28, 2018
existentialism
force-pushed
the
composer
branch
from
3113581
to
a7a920e
Compare
|
Yeah, re: testing, might be nice to have a util (maybe in composer itself?) that allows us to run ESLint tests for a rule so that any mods we make don't cause regressions without needing to include the them manually in this (or other) projects. |
kaicataldo
approved these changes
Mar 28, 2018
ljharb
reviewed
Mar 28, 2018
| /** | ||
| * @fileoverview Rule to flag use of constructors without capital letters | ||
| * @author Nicholas C. Zakas | ||
| * @copyright 2014 Jordan Harband. All rights reserved. |
There was a problem hiding this comment.
lol, i forgot i modified this rule forever ago
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
Refactor rules to use eslint-rule-composer
1 task
This was referenced Jun 6, 2021
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #135.
Closes #127.
Closes #137. (Sorry for the delay, and thanks for the PR @VictorHom!)
/cc: @kaicataldo @kentcdodds @not-an-aardvark