This repository has been archived by the owner on Aug 4, 2020. It is now read-only.
Camelcase - support for optional chaining #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@existentialism @hzoo is there something that I could do to get this reviewed faster? Would be nice to get rid of the fork :) |
|
Any progress on this guys? |
|
@existentialism have you had time to go this trough? :) |
|
@villesau sorry again for the delay, landing once this goes green |
|
Great, thanks for review @existentialism ! |
|
Hey guys this doesn't seem to be pushed to npm, is that on purpose? |
|
true. @existentialism could this be published in npm? |
|
@villesau released as 5.3.0! thanks again! |
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional chaining checks fails in the main repo, this PR reimplements (copy&paste over) the rule, and fixes the issues pointed in tests. tests are same as in main repo plus one added test for optional chaining. I wanted to keep changes as minimal as possible while satisfying every spec the rule has.
Using eslint-rule-composer didn't seem to be feasible since the implementation (e.g in case of duplicate checks) varies, and even more tests failed when just passing the rule trough it.
Easiest way to review this is to go commit by commit. First one is just copy&paste from eslint & some wire up.
ref: eslint/eslint#10848