Conversation
"use strict"; | ||
|
||
// Node types which are considered loops. | ||
var loopTypes = new Set([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we actually use Set
here since we don't know what version of node people are using?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a target minimum version? I can use an Object
instead of necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is nothing set in stone but I think we are mostly in keeping with eslint, which still supports 0.10.x i believe...my rule of thumb has been: es5
OK, I removed |
LGTM, I think the array will be fine, bc as you say the depth is not likely to be deep enough to make much of a difference. If it does pose an issue I'd be happy to revisit using Set, I don't think it would be too much trouble to require node 0.12+ but lets see how it goes. |
I'll try and get a release out in the next day or so |
@jquense Any word on a release? |
sorry about that, been a busy month thanks for the reminder |
No worries, I know how it goes 😄 |
Add no-await-in-loop rule.
Closes #20