This repository has been archived by the owner on Aug 4, 2020. It is now read-only.
Future-proofing #29
Merged
Future-proofing #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 25, 2015 09:46
The context passed into rule definitions will be frozen in eslint 2. It was briefly frozen in 1.10.0, but reverted in 1.10.1. (And yet, I couldn't get tests to pass with eslint 1.10.1 installed)
|
many thanks! |
|
Looks good - should we do a major version bump in case? |
|
@hzoo I almost suggested that, just to be extra-safe. I'm cool either way. |
|
I think that would be best - published 3.0 |
|
Thanks! |
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
Future-proofing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My original goal was to remove the dependency on
babel-core@5, since there's no actual usage of the module in this plugin (nor of thehelpers.jsfile, wherein the onlyrequire('babel-core')is located). By doing this, we reduce the amount of cruft installed by npm when users update to babel 6.I went through all the dependents of
eslint-plugin-babel, and none of them are requiringhelpers.js. Some of the dependents themselves depend onbabel-core, but that's not a reason to keep it as a dependency of this module.Incidentally, when running the tests after making my changes, I found weird errors related to the recent
Object.freeze()shenanigans upstream ineslint. Theoretically,eslint@1.10.1should have reverted those breaking changes (first reported as breakingeslint-plugin-react), but it's a good idea to stop modifying thecontextobject anyway, as the maintainers ofeslinthave expressed the intention of restoring that freeze ineslint@2.