This repository has been archived by the owner on Aug 4, 2020. It is now read-only.
Add type annotations to arrow-parens "as-needed" #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using optional type annotations, parentheses are required even for
single-argument arrow functions. Check for a `typeAnnotation` on the
single param and allow parentheses if it exists.
// good with "as-needed"
a => 5;
(a: string) => 5; // Previously this reported an error
// bad with "as-needed"
(a) => 5;
|
🐼 Anything I can do to help on this? We annotate all of our code, and we aren't able to enable this rule because it currently doesn't inspect the |
|
thanks for the ping and PR :) |
jquense
added a commit
that referenced
this pull request
Jan 22, 2016
Add type annotations to arrow-parens "as-needed"
|
@jquense Thanks! |
|
@jquense Any chance of a release? Looks like the last one was in November, and there have been several changes since then: v3.0.0...master |
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
…type-annotations Add type annotations to arrow-parens "as-needed"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using optional type annotations, parentheses are required even for
single-argument arrow functions. Check for a
typeAnnotationon thesingle param and allow parentheses if it exists.