This repository has been archived by the owner on Aug 4, 2020. It is now read-only.
Add an automated fix for arrow-parens #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
|
Maybe add a little thing to the docs like the rule is fixable like on the eslint website
-- nvm did it |
|
Also realized There was a previous PR for this #46 |
|
Also @jquense we should probably do something to track when the rule was forked from eslint so its easier to know how to update with upstream changes. Something simple we can do is add the git commit sha from where it was forked |
|
@hzoo sorry, should have taken a look through other PRs. Thanks very much for the quick merge/ fix to the documentation! |
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
…r-arrow-parens Add an automated fix for arrow-parens
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an automated fix for
babel/arrow-parens. If parens are needed, it adds them, if not, it removes them. Let me know if you'd like me to raise an issue for this in addition to the PR, or if you don't think this should be added.cc/ @hzoo