Skip to content
This repository has been archived by the owner on Aug 4, 2020. It is now read-only.

Update Dependencies #67

Merged
merged 3 commits into from
Jul 1, 2016
Merged

Update Dependencies #67

merged 3 commits into from
Jul 1, 2016

Conversation

kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Jul 1, 2016 •
edited
Loading

fixes #65

@kaicataldo
Copy link
Member Author

By the way, what is PhantomJS used for? Feel silly but I'm not seeing anything that actually uses it

@hzoo
Copy link
Member

hzoo commented Jul 1, 2016 •
edited
Loading

Looking into git blame on github, it seems that it was added in the initial commit but wasn't used for anything? I say we can remove it

Also I guess this is breaking since peerDep with eslint 2 (although we didn't change src)

@hzoo hzoo merged commit 078258a into babel:master Jul 1, 2016
nicolo-ribaudo pushed a commit to babel/babel that referenced this pull request Nov 14, 2019
@kaicataldo
Update Dependencies (babel/eslint-plugin-babel#67)
6e4d44f 
* Update Dependencies

fixes babel/eslint-plugin-babel#65

* Remove PhantomJS & is-my-json-valid

PhantomJS & is-my-json-valid is not actually used anywhere

* Change ESLint peerDependency version back to >=1.0.0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update eslint/babel-eslint versions
2 participants
@kaicataldo @hzoo