Skip to content
This repository has been archived by the owner on Aug 4, 2020. It is now read-only.

Add support for async functions in arrow-parens #9

Merged
merged 1 commit into from
Aug 16, 2015
Merged

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Aug 15, 2015

*/
function parens(node) {
var token = context.getFirstToken(node);
if (node.async) token = context.getTokenAfter(token);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this line like I mentioned in #8 (comment)

hzoo added a commit that referenced this pull request Aug 16, 2015
Add support for async functions in arrow-parens
@hzoo hzoo merged commit 9d8f79a into master Aug 16, 2015
@hzoo
Copy link
Member Author

hzoo commented Aug 16, 2015

@leebyron Ok should be fixed. Also tested in express-graphql https://github.com/graphql/express-graphql/blob/34c14410b2879355e192462bdd159df884c28537/.eslintrc#L38

With eslint@1.1.0, babel-eslint@4.0.7, eslint-plugin-babel@2.1.0
(which I will publish now)

@hzoo
Copy link
Member Author

hzoo commented Aug 16, 2015

@jquense Oh can you add me to the npm users or publish 2.1.0?

@jquense
Copy link
Contributor

jquense commented Aug 16, 2015

@hzoo I can publish tho a far amount of tests are failing...are these false positives?

sorry forgot to npm install first. publishing now

@jquense jquense deleted the arrow-parens branch August 16, 2015 02:44
@hzoo
Copy link
Member Author

hzoo commented Aug 16, 2015

Um it it looks like it passes to me? https://travis-ci.org/babel/eslint-plugin-babel

screen shot 2015-08-15 at 10 44 43 pm

@hzoo
Copy link
Member Author

hzoo commented Aug 16, 2015

K thanks - we should add a travis badge to the readme

@jquense
Copy link
Contributor

jquense commented Aug 16, 2015

good call :) and I will add you to the npm users as well, as soon as I get a free moment

@spalger
Copy link

spalger commented May 16, 2016

I'm seeing this again, is it just me?

Using babel-eslint 6.0.4 with eslint 2.10.1

image

nicolo-ribaudo pushed a commit to babel/babel that referenced this pull request Nov 14, 2019
Add support for async functions in arrow-parens
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async arrow functions always fail arrow-parens rule
3 participants