Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for incorrect isparta import in gulpfile.babel.js #289

Merged
merged 1 commit into from
Dec 29, 2015
Merged

Fix for incorrect isparta import in gulpfile.babel.js #289

merged 1 commit into from
Dec 29, 2015

Conversation

do0g
Copy link
Contributor

@do0g do0g commented Nov 25, 2015

Currently coverage is broken in the generator and gulp coverage fails with the following error:

[20:13:29] TypeError: Cannot read property 'Instrumenter' of undefined
    at Gulp._coverageOrig (...

The cause of this is that there is no default export for isparta. This PR imports the entire module under an isparta variable so the property reference to the instrumenter works as expected.

@do0g
Copy link
Contributor Author

do0g commented Nov 26, 2015

Neglected to mention this regards the new gulpfile.babel.js

jamesplease added a commit that referenced this pull request Dec 29, 2015
Fix for incorrect isparta import in gulpfile.babel.js
@jamesplease jamesplease merged commit 92aaee2 into babel:master Dec 29, 2015
@jamesplease
Copy link
Member

Thanks! I'll cut a release today.

This was referenced Dec 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants