Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.0.0 #240

Merged
merged 29 commits into from
Dec 30, 2015
Merged

6.0.0 #240

merged 29 commits into from
Dec 30, 2015

Conversation

jamesplease
Copy link
Member

Will resolve #236

Todo:

var firstBuild = true;

// This empty stream might seem like a hack, but we need to specify all of our files through
// the `entry` option of webpack. Otherwise, it ignores whatever file(s) are placed in here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you just start with the webpackStream then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'cuz I'm a noob. I'll try that

@jamesplease
Copy link
Member Author

I just realized that simply using gulpfile.babel.js removes the need to ever run _registerBabel, as Babel gets registered automatically with Babel'd gulpfiles. So that's something I can update to clean up the Gulpfile.

@jamiebuilds
Copy link
Contributor

Hmm... The way gulp should probably be implementing that is to limit the register to only the gulpfile.

@jamesplease
Copy link
Member Author

Hmm... The way gulp should probably be implementing that is to limit the register to only the gulpfile.

Yeah? I wonder if it's a bug, then. It's working over here.

We were accidentally binding the context of the function. Luckily, this was never released!

Resolves #249
runSequence was added as a stop-gap to prevent Browserify from breaking. New error
handling makes it safe to attempt to build even the worst of code. Therefore, runSequence
is no longer necessary.

Resolves #254
Also ensure that the Gulpfile passes linting.

Resolves #256 and #253
Webpack is now used to build the distributed build.
Removes the need to update two objects.

It's too easy to update one and for get the other. It wasn't consistent as it was.

And it's in the test/setup directory which seems pretty self explanatory.
This was referenced Dec 30, 2015
@jamesplease
Copy link
Member Author

Alright, finally gonna cut this release then start work on the next version, which will use Babel v6!

jamesplease added a commit that referenced this pull request Dec 30, 2015
@jamesplease jamesplease merged commit 7d87806 into master Dec 30, 2015
@jamesplease jamesplease deleted the v6.0.0 branch December 30, 2015 18:10
@jamesplease jamesplease changed the title WIP - 6.0.0 6.0.0 Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v6
3 participants