Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edge doesn't support Object spread properties. The JSX plugin here generates them, which means we're producing code that breaks in Edge.
Most users have
@babel/proposal-object-rest-spread
configured, and would see JSX spread transpiled to Babel's full object spread output with helpers. If they've configured that plugin withuseBuiltIns:true
, the result is cleanObject.assign
calls, though this is inconsistent with the spec behavior of spread properties (but not JSX Spread).Instead, this PR changes
preset-modules
to transpile JSX Spread Attributes intoObject.assign()
calls, which are natively supported in all ES Modules-supporting browsers. The old behavior is still available, but is now gated behind a newuseSpread
option in the plugin (not the preset).before:
Size (uncompressed): 1.1kB
after:
Size (uncompressed): 80 bytes
h/t @devongovett who noticed this!