Skip to content

Commit

Permalink
Incorporate review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
peey committed Jul 21, 2017
1 parent 822e4f3 commit eebfdaa
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions _posts/2017-07-02-gsoc-peey-1.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ When I initially joined Babel, and was not-so-familiar with the codebase, every
issue I encountered was almost instantly answered after I posted it in Babel’s
chatroom, which left me with the (wrong) impression that perhaps the maintainers
are some god-like figures who know it all and that everyone’s expected to adhere
to same fictitious standards.
to the same fictitious standards.

Even after becoming familiar with the codebase, I was submitting PRs without
proper documentation under the assumption that it took me a while to solve the
Expand All @@ -58,19 +58,19 @@ sometimes you’ll have to search for yourself — and that’s how it should be
In open source, there are a lot of people who want to contribute, but are unable
to because they don’t know how to code / they don’t know how to present PRs /
they don’t know what the project wants / they don’t know what the maintainers
want / a ton of other things. A lot of the times you’ll find help along the way,
want / a ton of other things. A lot of times you’ll find help along the way,
but a lot of that is controlled by factors beyond your control.<sup><a href="#footnotes">3</a></sup>

One of the joys of getting your PR merged is not just the programming but
somehow making the project move forward in the way it is expected to be moved
forward. And doing that by somehow identifying what the project needs and being
able to deliver that.

In order to merge this PR I had find people and talk to them — people who use
In order to merge this PR I had to find people and talk to them — people who use
decorators, people who are interested in seeing an implementation of decorators,
people who want to contribute to babel for decorators. After getting consensus
on how to move forward<sup><a href="#footnotes">4</a></sup>, I had to go through the spec and all the existing
discussion surrounding it so that my understanding of the spec could be up to
discussions surrounding it so that my understanding of the spec could be up to
speed with other people.

And finally — the most important part which I think got this PR the number of
Expand All @@ -91,14 +91,14 @@ the code rather than the other way around)
And that’s what did it! (or so I think). So there’s the mystery unraveled — A PR
with unusually high number of reviews¹.

**PS**: I wanted to share my personal experience experience with this blog post,
**PS**: I wanted to share my personal experience with this blog post,
not write a guide to be followed or a technical blog post. Therefore, some
statements which I make may not hold true in general or may be debatable, so
they should just be read in the context of the experience I narrate.

Also note that if you’re looking for decorators support in Babel, we still have
a long way to go. This is just the parser and work on the transform (which
converts your code to functionally equivalent ES5)is yet to be done. But now
converts your code to functionally equivalent ES5) is yet to be done. But now
that we’ve made the decisions that needed to be made, things will move more
smoothly from here onwards.

Expand All @@ -110,7 +110,7 @@ notes](https://github.com/babel/notes/blob/master/2017-06/june-21.md#priority-to
Perhaps you could help us with this. Drop by [our slack
chatroom](https://slack.babeljs.io/) and offer your help!
2. I feel that the myth stems from the fact that when you’re new to the project the
mentors definitely do know more about the project than you so
mentors definitely do know more about the project than you
3. (to illustrate) Some random factors which might affect the chances of you
getting help:
- If someone was online who worked on the same thing when you post a question on
Expand All @@ -125,5 +125,7 @@ backwards-compatible so we were unsure on how we should introduce support for
the new spec without causing much disruption for people who use Babel. We
finally decided that we’ll be introducing this PR as a opt-in to allow people to
migrate at their own pace.
5. Originally posted [here on medium](https://medium.com/@peey/personal-experiences-at-babel-1-a-pr-with-unusually-high-number-of-reviews-5cb49ee71897)

## Outro
Peeyush Kushwaha is a [GSoC 2017](https://summerofcode.withgoogle.com/organizations/5842528113786880/#6632162202746880) student. This was originally posted [here on medium](https://medium.com/@peey/personal-experiences-at-babel-1-a-pr-with-unusually-high-number-of-reviews-5cb49ee71897)

0 comments on commit eebfdaa

Please sign in to comment.