Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the gsoc blog post #1279

Merged
merged 5 commits into from
Aug 11, 2017
Merged

Add the gsoc blog post #1279

merged 5 commits into from
Aug 11, 2017

Conversation

peey
Copy link
Contributor

@peey peey commented Jul 21, 2017

@xtuc xtuc added the blog label Jul 21, 2017
Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small minor nits, but awesome work @peey! 👍

aware of the whole issue, the discussion surrounding it, and have familiarity
with the part of the codebase that the PR makes changes to.<sup><a href="#footnotes">1</a></sup>

When I initially joined Babel, and was not-so-familiar with the codebase, every
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and that everyone’s expected to adhere to the same fictitious standards

In open source, there are a lot of people who want to contribute, but are unable
to because they don’t know how to code / they don’t know how to present PRs /
they don’t know what the project wants / they don’t know what the maintainers
want / a ton of other things. A lot of the times you’ll find help along the way,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of the times you’ll find help along the way

forward. And doing that by somehow identifying what the project needs and being
able to deliver that.

In order to merge this PR I had find people and talk to them — people who use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to merge this PR I had to find people

also, babel -> Babel

spec and all the existing discussions surrounding

And that’s what did it! (or so I think). So there’s the mystery unraveled — A PR
with unusually high number of reviews¹.

**PS**: I wanted to share my personal experience experience with this blog post,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extra experience


Also note that if you’re looking for decorators support in Babel, we still have
a long way to go. This is just the parser and work on the transform (which
converts your code to functionally equivalent ES5)is yet to be done. But now
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space between ES5)is

notes](https://github.com/babel/notes/blob/master/2017-06/june-21.md#priority-topics)).
Perhaps you could help us with this. Drop by [our slack
chatroom](https://slack.babeljs.io/) and offer your help!
2. I feel that the myth stems from the fact that when you’re new to the project the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so at the end seems extraneous?

@hzoo
Copy link
Member

hzoo commented Jul 21, 2017

we should mention somewhere that you are part of gsoc (you can ignore the ci fail, looks like a lot of random remark errors). (I should just write up a blogpost about how we are participating in that actually)

@peey
Copy link
Contributor Author

peey commented Jul 21, 2017

@existentialism fixed those! @hzoo : added that info.

Also decided to run it through Grammarly and found that I've been using too many commas which aren't needed. I hope they can stay, because when I wrote this I was using them as conversation pauses!

@hzoo hzoo mentioned this pull request Aug 1, 2017
@babel-bot
Copy link
Contributor

babel-bot commented Aug 11, 2017

Deploy preview ready!

Built with commit cc04f11

https://deploy-preview-1279--babel.netlify.com

@hzoo hzoo merged commit 3418d9e into babel:master Aug 11, 2017
@Daniel15
Copy link
Member

This is failing lint, which is breaking the Travis build. Could you please fix it?

- ./_site/blog/2017/08/11/personal-experiences-at-babel-1-a-pr-with-unusually-high-number-of-reviews.html
  *  internally linking to #footnotes, which does not exist (line 9)
     <a href="#footnotes">1</a>
  *  internally linking to #footnotes, which does not exist (line 9)
     <a href="#footnotes">2</a>
  *  internally linking to #footnotes, which does not exist (line 9)
     <a href="#footnotes">3</a>
  *  internally linking to #footnotes, which does not exist (line 9)
     <a href="#footnotes">4</a>
rake aborted!
HTML-Proofer found 4 failures!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants