Add JUnit support #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
started. Started some light code clean up -- mostly not referencing static members and methods from an instance variable, but properly from the class.
avneettoor
previously approved these changes
Nov 2, 2021
congoamz
previously approved these changes
Nov 2, 2021
robverschoor
dismissed stale reviews from congoamz and avneettoor
via
c05b930
robverschoor
approved these changes
Nov 3, 2021
hsuamz
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding JUnit 5 for unit testing and JaCoCo for code coverage.
Wrote a couple of tests to get us started and resolved logic and edge case bugs those tests exposed.
Started some light clean up of the Java code - mostly not referencing static members and methods from instance variables. We really need to look at splitting the utilities class into its 2 uses right now - runtime config of the report generator and truly static helper functions and constants.
Note that I did not add a reporting section to the pom file, so if you want to look at the code coverage reporting, run
mvn jacoco:reportafter a clean build and test and then you can see the reports intarget/site/jacoco/index.html.Issues Resolved
Resolves Issue #17
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.