Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vector version and related test file changes (#2674) #2684

Conversation

KushaalShroff
Copy link
Contributor

In 0.7 version of pgvector, there are now new types added. Although we do not support it entirely with this commit, we fix the changes required to the test files. These changes, change in error messages and adding explicit casts while calling a the SQL utility function, are expected and have been updated in the pgvector extension as well.

Issues Resolved
BABEL-5058

Signed-off-by: Kushaal Shroff kushaal@amazon.com

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…stgresql#2674)

In 0.7 version of pgvector, there are now new types added. Although we do not support it entirely with this commit, we fix the changes required to the test files. These changes, change in error messages and adding explicit casts while calling a the SQL utility function, are expected and have been updated in the pgvector extension as well.

Issues Resolved
BABEL-5058

Signed-off-by: Kushaal Shroff kushaal@amazon.com
@coveralls
Copy link
Collaborator

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9663076387

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.965%

Totals Coverage Status
Change from base Build 9646273557: 0.0%
Covered Lines: 41850
Relevant Lines: 57356

💛 - Coveralls

@KushaalShroff KushaalShroff merged commit 72d174e into babelfish-for-postgresql:BABEL_3_6_STABLE Jun 26, 2024
40 checks passed
@KushaalShroff KushaalShroff deleted the vector_3_stable branch June 26, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants