Possible stray 'n' prefix for strndup. #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babelouest
reviewed
Nov 6, 2016
| @@ -585,7 +585,7 @@ int mhd_iterate_post_data (void * coninfo_cls, enum MHD_ValueKind kind, const ch | |||
|
|
|||
| struct connection_info_struct * con_info = coninfo_cls; | |||
| size_t cur_size = size; | |||
| char * data_dup = nstrndup(data, size); // Force value to end with a NULL character | |||
There was a problem hiding this comment.
Actually, the n* functions are defined in orcania repository which is a mini project containing among others nstrdup and nstrndup.
This functions is created to avoid a crash when a data is NULL or size is 0.
Ulfius depends on Orcania to compile:
https://github.com/babelouest/orcania
There was a problem hiding this comment.
Ah, that explains it. I started getting a missing reference after I updated the repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.