Skip to content
This repository has been archived by the owner on Apr 19, 2021. It is now read-only.

Upgrade Sapper and update issue link #7

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Upgrade Sapper and update issue link #7

merged 1 commit into from
Jun 16, 2020

Conversation

benmccann
Copy link
Contributor

No description provided.

@babichjacob
Copy link
Owner

The workaround is still necessary for me on Sapper >= 0.27.15.

For example, try passing

{
	files: ["not-exist.ts"],
}

as options to typescript(/* here */). You get the opaque error

@rollup/plugin-typescript: Couldn't process compiler options

without the explanatory warning

(typescript plugin) @rollup/plugin-typescript TS5023: Unknown compiler option 'files'.

@benmccann
Copy link
Contributor Author

Gahhh!!!!! 😭 I really thought I had them all fixed

@benmccann benmccann closed this Jun 11, 2020
@benmccann benmccann reopened this Jun 11, 2020
@benmccann
Copy link
Contributor Author

benmccann commented Jun 11, 2020

Actually, I just tested this and the error showed up for me:

cross-env NODE_ENV=production sapper build --legacy

Building...
@rollup/plugin-typescript TS5023: Unknown compiler option 'files'.

[!] (plugin typescript) Error: @rollup/plugin-typescript: Couldn't process compiler options
Error: @rollup/plugin-typescript: Couldn't process compiler options

Maybe the issue is just that it printed multiple errors and you missed the explanation above the last error? I'm not sure what Rollup would do here, but if we can make the output closer I guess that we could make an enhancement request to Sapper

@babichjacob
Copy link
Owner

Oh, so it works during prod but not dev

@benmccann
Copy link
Contributor Author

Ohh. Yeah, I was testing with npm run build

I filed an issue and updated this PR to use the new issue link. It's probably still worth upgrading Sapper here since it fixes three other issues with swallowing errors. Too bad there's a fourth 😛

@benmccann benmccann changed the title Upgrade Sapper and remove workaround Upgrade Sapper and update issue link Jun 16, 2020
@babichjacob babichjacob merged commit ddd140d into babichjacob:master Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants