You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Severity
Quite frustrating for users who don't know about this bug. Not so bad for me since I know it exists and can work around it in my rollup config or by running npm run build instead
Describe the bug
Sapper doesn't flush Rollup warnings when it receives an error in
dev
modeI think these warnings only apply to errors in the
rollup.config.js
fileTo Reproduce
git clone git@github.com:babichjacob/sapper-typescript-graphql-template.git
Pass
as options to
typescript(/* here */)
. You get the opaque errorExpected behavior
Information about your Sapper Installation:
dev
modeSeverity
Quite frustrating for users who don't know about this bug. Not so bad for me since I know it exists and can work around it in my rollup config or by running
npm run build
insteadAdditional context
Thanks to @babichjacob for the testing. He discovered it in babichjacob/sapper-typescript-graphql-template#7
#1236 flushed warnings in
compile
. I didn't realize thatdev
mode might not callcompile
. It looks to me like it instead calls a different methodwatch
. We should flush warnings in that case as well. I got most of the last fix from Rollup's cli. Here's what they do: https://github.com/rollup/rollup/blob/08a6255ce0af2dca775e828919f035b433b35fed/cli/run/watch-cli.ts#L93The text was updated successfully, but these errors were encountered: