Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open page at last reading position #86

Closed
babluboy opened this issue Jun 14, 2017 · 4 comments
Closed

Open page at last reading position #86

babluboy opened this issue Jun 14, 2017 · 4 comments
Assignees
Milestone

Comments

@babluboy
Copy link
Owner

On opening a previously read book the page should scroll down to the last read position.
This issue is created from the comments in issue #85

@babluboy babluboy self-assigned this Jun 22, 2017
@babluboy babluboy added this to the 0.9 milestone Jun 22, 2017
@babluboy
Copy link
Owner Author

babluboy commented Jul 8, 2017

Completed adding code to set the last read page position in two scenarios:
1- When the "Return to library" button on the header is clicked to exit a book
2- When the application is closed in reading view

The scroll to the last recorded position is applied only once when the book is opened by:
1- Selecting the book for reading in the library
2- Opening a book in File Explorer using Bookworm and the book is already present in Bookworm's library

@jacksonbenete
Copy link

jacksonbenete commented Nov 15, 2018

When you "check word meaning" and then "resume" the app lose the last reading position which is really annoying.
Should the dictionary text of the function be displayed in a pop-up or something instead of moving the reader to another window view?

Edit: I'm in 1.1.0.

@jacksonbenete
Copy link

You will also lose the last reading position when adjusting reading preferences other than font size.

@babluboy
Copy link
Owner Author

@jacksonbenete Thanks for the time to open this issue. Definitely agree with you.

The reason I have got Word Meaning open in the info section is to expand the details in the future to include Wikipedia and also preferences to use a local dictionary when no internet is present

Both preferences and word meaning should return to the last read position when the page loads. Should not be hard to use the same logic when re-opening Bookworm to continue reading.

@babluboy babluboy reopened this Nov 15, 2018
babluboy added a commit that referenced this issue Dec 2, 2018
…ion after changing preferences or resuming from Info (Issue #86)
@babluboy babluboy closed this as completed Dec 2, 2018
@babluboy babluboy modified the milestones: 0.9, 1.1.2 Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants