Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete (instead of deactivate) completed timers #109

Closed
Tracked by #515
cdubz opened this issue Feb 3, 2020 · 9 comments
Closed
Tracked by #515

Delete (instead of deactivate) completed timers #109

cdubz opened this issue Feb 3, 2020 · 9 comments
Labels
enhancement Feature requests or improvements to existing functionality
Milestone

Comments

@cdubz
Copy link
Member

cdubz commented Feb 3, 2020

I don’t think there is any reason to keep timers around after that have completed and been used for an entry. Instead they should just be removed. I’m interested to hear if any users have a use case that involves keeping them around.

This relates to #108, which is planned for a 1.x release.

@cdubz cdubz added this to the v2.0.0 milestone Feb 3, 2020
@BradleyShaner
Copy link

I kept yelling at my wife for leaving so many unused timers around because I assumed they would disappear automatically! No complaints here.

@cdubz cdubz added the enhancement Feature requests or improvements to existing functionality label Aug 20, 2021
@cdubz cdubz removed this from the v2.0.0 milestone Sep 9, 2021
@cdubz cdubz mentioned this issue Aug 4, 2022
13 tasks
cdubz added a commit that referenced this issue Aug 14, 2022
@cdubz cdubz added this to the 2.0.0 milestone Aug 14, 2022
@cdubz cdubz closed this as completed Aug 14, 2022
cdubz added a commit that referenced this issue Mar 25, 2023
@cdubz
Copy link
Member Author

cdubz commented May 3, 2023

Re-opening to correct automated release notes dealy.

@cdubz cdubz reopened this May 3, 2023
@cdubz cdubz closed this as completed May 3, 2023
@bluesmokeresearch
Copy link

A little late to the party here, but I am using the android app by Paul and it relies on re-using the same timers over and over to make them quickly available. Reading the latest release notes, I believe the timers autodelete change (Timers no longer have an "end" and cannot be stopped -- only deleted or used to create a new entry with times) means they will have to be recreated every time either in the webpage outside the app or with a 'recreate default timers' command in the app and it will essentially break the workflow.

I see how for many people the autodelete would be the preferred and probably default setting though. One option is that the app could be updated to adopt a new model or timer management, but depending on how deep the change was to the code in 2.0.0, perhaps the timer end vs delete could be an settings toggle in babybuddy?

@MrApplejuice
Copy link
Contributor

MrApplejuice commented May 18, 2023

@bluesmokeresearch

Hey there! Yeah, @cbudz made me (and others) aware of the pending breaking change over here: #515 (comment) . And you are very right that this will spill disaster for the core-feature of the Android app.

I am therefore trying to lay down a sort-of "mad dash" to push an update in time for the 2.0 release of babybuddy that will make the app compatible with either 1.x or 2.x before BabyBuddy 2.0 goes live. You can follow the progress over here: https://github.com/MrApplejuice/BabyBuddyAndroid/tree/fix-v2.0-breakage

Unfortunately, the code-quality of the app's timer-implementation was a bit "meh" so this took me a little while to fix things. I hope that I will have something in working order by next week, which then needs to go through a short test-phase and then can be published. So ETA ~27th of May, I hope!

@bluesmokeresearch
Copy link

@MrApplejuice Ah that is exciting news! We are very thankful for the app and look forward to it pushing out :)

@MrApplejuice
Copy link
Contributor

@bluesmokeresearch

FYI, I just started the app-store release for version 2.0 compatibility: #515 (comment)

If you use the manually installed version published on GitHub, you can download the APK from here instead: https://github.com/MrApplejuice/BabyBuddyAndroid/releases/tag/v2.0.0

@MrApplejuice
Copy link
Contributor

MrApplejuice commented May 25, 2023

We are very thankful for the app and look forward to it pushing out :)

Thank you for the kind words btw!

@bluesmokeresearch
Copy link

@MrApplejuice I receive the OTA update from the play store on all our devices by yesterday morning so I will update the main server soon and report back. Thanks again.

@MrApplejuice
Copy link
Contributor

I hope that everything will work sufficiently well! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements to existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants