-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release version 2.0.0 #515
Comments
Will it be totally breaking or is the intention to be able to migrate data from v1 to v2? |
@whnr my intention is for there to be a migration path using regular database migrations. I'm not being too ambitious here with the 2.0.0 tag so I'm fairly confident that will be achievable. |
@jcgoette @MrApplejuice @OttPeterR curious to get y'alls eyes on the v2 changes (see draft release notes above) w.r.t. your integrations! |
Thanks! Yeah... the Android app will be "kaputt" when this is made live: Delete (instead of deactivate) completed timers #109 It was anyway my intention to give this a rework this in the app. I would like to have some time to deploy a hotfix for this if at all possible. Is there a schedule for the major-release by any chance? I think that I can have a fix ready |
@MrApplejuice no real rush here. I’m happy to wait til those of you with known integrations are ready to roll. |
Hey thanks! I still think that you should probably think about setting a deadline for the v2 release, otherwise you might wait a long time should projects become dormant. But nonetheless, thank you for the heads-up! I will try and fix my timer-controls asap! |
Yeah that’s fair. We’ve got a long vacation coming up so I’m hesitant to drop it and then disappear hah. My rough plan is to release near the end of the month. Let’s say 26 May 👍 |
I'll try to get it spun up this weekend. Looking forward to it! |
Appreciate the heads up! I think those breaking changes should be fine. I like moving more things to the settings rather than env vars. The timer changes seem interesting, would there be a way to use that new architecture to note that a toddler woke up in the middle of the night and not have to get rid of the original sleep timer that spanned the whole night? As for timeline expectations, I don't have a lot of personal dev time in the next few weeks ( |
Thanks for the heads up! Are you still accepting PRs for this release? @Cadair has actually started working on fixing the HA integration, but I'm thinking using the new site-wide settings model to create an API endpoint exposing the site's BB version would be useful for my integration. |
@jcgoette sure thing! |
Oh oops also pinging @btoconnor re: #515 (comment) |
@cdubz I should be able to look at this next week - thanks for the ping! |
Alright! My app has been updated, I released it on GitHub and on the play-store it is currently "in review": And here the GitHub release: https://github.com/MrApplejuice/BabyBuddyAndroid/releases/tag/v2.0.0 This was a crunch to get this out in time... had to change thousands of lines of code. Kind of my fault for not implementing the right level of abstraction from the get-go though! 🤷 Anyhow, it typically takes a few days for the app store to approve the change. So I would not mind if the release can wait a few more days... but might not be actually necessary. I guess it will take some time anyways until the update proliferates to other servers. Again... dunno 🤷 Thanks again for the tap on the back so that this could be fixed and rolled out in a timely manner! |
Well 26 May came and went 😄 I'm still getting readjusted from a vacation and have a few issues to review that may slow down the 2.0.0 release. Takin' a look now 👀 |
Ok it looks like the only thing I still want to poke around on is #644 (comment). Will try to do that in the next few days and then move the release along. |
👋 just pushed a v2.0.0-beta2 release taking care of some of the bugs that popped up. #644 is good again. Think this is pretty much there... |
Just finding some time now to get a look at this - are there docker images for the beta releases? I'm not seeing them on https://hub.docker.com/r/linuxserver/babybuddy I can set up something without docker, just a little easier for me to use the images there. I still haven't found a great workflow for testing the Alexa integration for a parallel instance of the web server... |
@btoconnor can you use |
FTR I'm about ready for this -- just waiting on finalization in #665 as a last minute addition. |
And we're off! 🎉 |
Leaving some notes here even though the issue is closed. I finally got around to testing this out (sorry for delay). Most of the actions seem to still work fine, except for concluding timers. I'll hopefully get to fix that soon. I'll leave further comments / issues on the alexa repo |
I have started work recently on a v2 branch and will try to focus future efforts on moving that forward with some issues with breaking changes. I'll use this issue on tracking for the relevant issues that need to be completed.
Planned release date
26 May
Draft release notes
Breaking changes
TIME_ZONE
variable no longer supported. User timezone can be set from user settings.NAP_START_MIN
andNAP_START_MAX
variables no longer supported. Nap time parameters can be set from site settings.Timer
modelend
andduration
fields removed. There is no longer a concept of "active" vs. "inactive" timers.active
filter onTimer
model no longer supported.PATCH /api/timers/$x/stop
endpoint no longer supported.Major changes
v2.0.0
TIME_ZONE
environment variable configuration #301USE_24_HOUR_TIME_FORMAT
option (rely ondatetime-local
form fields) #638Stretch goals
The text was updated successfully, but these errors were encountered: