Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom en date formats interfere with en-GB language #324

Closed
cdubz opened this issue Oct 27, 2021 · 1 comment · Fixed by #332
Closed

Custom en date formats interfere with en-GB language #324

cdubz opened this issue Oct 27, 2021 · 1 comment · Fixed by #332
Labels
bug Reports of unexpected problems or errors help wanted Issues where maintainers could use assistance from others i18n/L10n Issues relating to internationalization and/or localization

Comments

@cdubz
Copy link
Member

cdubz commented Oct 27, 2021

@cdubz Thanks for trying to get #321 sorted.

I've had a quick test of the latest commit (fae764a) and it wasn't fully working for me. (This should probably be moved to an issue)

Data input is working correctly and the input controls use the correct format, but the display list pages are not.
Not sure if this is expected or not (from a tech perspective), but the default time format when en-GB is selected remains 12h not 24h.

It seems that Timeline and Children are displaying correctly, but the following are not:

Notes
Temperature
Weight
All of the Activity list views.
Timer list view.

The odd thing was Timer (detailed view) was showing the date correctly (albeit with the default 12h time format), but when switching using USE_24_HOUR_TIME_FORMAT=True the time format was correct but not the date.

I was using python 3.8.12 if that makes any difference.

Originally posted by @Amith211 in #321 (comment)

@cdubz cdubz added bug Reports of unexpected problems or errors i18n/L10n Issues relating to internationalization and/or localization help wanted Issues where maintainers could use assistance from others labels Oct 27, 2021
@cdubz
Copy link
Member Author

cdubz commented Oct 27, 2021

@Amith211 I got too focused on making sure the date inputs work and forgot that the formats for date strings are still applied to any en language. So this all kind of makes sense based on the solution I came up with. Now I’m just really not sure how to address this with Django’s date format system…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Reports of unexpected problems or errors help wanted Issues where maintainers could use assistance from others i18n/L10n Issues relating to internationalization and/or localization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant