Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve asset minification #492

Closed
cdubz opened this issue Jun 29, 2022 Discussed in #491 · 2 comments · Fixed by #550
Closed

Improve asset minification #492

cdubz opened this issue Jun 29, 2022 Discussed in #491 · 2 comments · Fixed by #550
Labels
enhancement Feature requests or improvements to existing functionality good first issue Good candidates for simple work for first time contributors help wanted Issues where maintainers could use assistance from others

Comments

@cdubz
Copy link
Member

cdubz commented Jun 29, 2022

Discussed in #491

Originally posted by gbballpack June 28, 2022
Using Cloudflare with Baby Buddy, Baby Buddy running inside of Docker with an external reverse proxy, Cloudflare is able to minify about 80 KiB from the vendor JS file.

Would it be possible to have everyone run a minified vendor JS file? Minified files generally run quicker and can reduce power consumption when on mobile compared to non-minified JS files.

I am curious if it is possible to share the benefits of the minified JS with those not using Cloudflare?

Before and after screenshots are attached, using https://web.dev/measure to verify the Cloudflare JS minification.
IMG_1425
IMG_1426
@cdubz cdubz added enhancement Feature requests or improvements to existing functionality help wanted Issues where maintainers could use assistance from others good first issue Good candidates for simple work for first time contributors labels Jun 29, 2022
@cdubz cdubz mentioned this issue Aug 4, 2022
Closed
13 tasks
@mikejgray
Copy link
Contributor

Would you still like help on this?

@cdubz
Copy link
Member Author

cdubz commented Oct 15, 2022

Yes for sure!

@mikejgray mikejgray mentioned this issue Oct 20, 2022
Merged
cdubz pushed a commit that referenced this issue Oct 22, 2022
@mikejgray @cdubz
feat: minify vendor.js
3c0df57 
Closes #492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature requests or improvements to existing functionality good first issue Good candidates for simple work for first time contributors help wanted Issues where maintainers could use assistance from others
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: minify vendor.js
2 participants
@cdubz @mikejgray