Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: who comparative data in weight chart #512

Closed
fapo85 opened this issue Aug 3, 2022 · 11 comments · Fixed by #708
Closed

Feature Request: who comparative data in weight chart #512

fapo85 opened this issue Aug 3, 2022 · 11 comments · Fixed by #708
Labels
enhancement Feature requests or improvements to existing functionality

Comments

@fapo85
Copy link

fapo85 commented Aug 3, 2022

Our pediatrician uses the Percentiles weight data to assess our child's weight development.

I would like to be able to visualize this as well.

The Percentiles weight data are comparative data to be able to estimate the development.
These are published by the World Health Organization.
https://www.who.int/tools/child-growth-standards/standards/weight-for-age

A distinction is made between male and female gender.

I would like to be able to fade in these in the weight chat with to be able to estimate the development.

@cdubz
Copy link
Member

cdubz commented Aug 3, 2022

Hm. The challenge here would be that Baby Buddy does not enforce any particular unit for weight (or anything else) so supplementing with this data would be pretty complex. Unless that changes at some point this is probably best left as an exercise to individual users with Baby Buddy's API.

And I would be happy to boost anything that someone builds and releases 😃

@cdubz cdubz added the enhancement Feature requests or improvements to existing functionality label Aug 3, 2022
@fapo85
Copy link
Author

fapo85 commented Aug 3, 2022

hmm maybe better that one makes it generally.
So the function that you say I can just put lines in the chart.
That can be for comparison other children.
but also the who comparative data in different units.

but I think now the feature is too big :-D

@Cadair
Copy link

Cadair commented Mar 18, 2023

I was thinking about adding this, I don't really want to have to spin up something else outside of BB itself to do this comparison. How about adding buttons to add the percentile lines in kg and lb so if people are using those units they can toggle on the lines?

@cdubz
Copy link
Member

cdubz commented Mar 18, 2023

Hmmmm I could see that working. Definitely open to a PR.

I'd also consider committing to kg (making this slightly easier) but that probably have to happen in a major release.

@Cadair
Copy link

Cadair commented Mar 18, 2023

I'd also consider committing to kg

The way it should be 😉

@cdubz
Copy link
Member

cdubz commented Mar 18, 2023

Haha yes I increasing feel that way. If Baby Buddy commits to anything it will be metric.

@barakplasma
Copy link
Contributor

barakplasma commented Sep 18, 2023

I took the liberty of making a plotly.js chart from the WHO data https://codepen.io/barakplasma/pen/bGOoZEe?editors=1011

I'm not crazy about my color scheme, but that's easy to fix
image

@barakplasma
Copy link
Contributor

barakplasma commented Sep 20, 2023

graph of weight vs percentiles
starting to take shape
example from who:
Weight-for-age BOYS Birth to 6 months (percentiles)

@cdubz
Copy link
Member

cdubz commented Sep 20, 2023

Very cool @barakplasma -- one thing to keep in mind is Baby Buddy doesn't currently have any way to set a child's sex. So that is something we'll have to add in support of this as well.

barakplasma added a commit to barakplasma/babybuddy that referenced this issue Sep 20, 2023
barakplasma added a commit to barakplasma/babybuddy that referenced this issue Sep 20, 2023
barakplasma added a commit to barakplasma/babybuddy that referenced this issue Sep 20, 2023
barakplasma added a commit to barakplasma/babybuddy that referenced this issue Sep 20, 2023
barakplasma added a commit to barakplasma/babybuddy that referenced this issue Sep 20, 2023
barakplasma added a commit to barakplasma/babybuddy that referenced this issue Sep 21, 2023
cdubz added a commit that referenced this issue Sep 27, 2023
* feat: weight percentiles report
#512

* fix: formatting on weight percentile graph to extend out only 1 day more than the last weigh in date
#708 (comment)

* feat: pre-commit lint with black hook
tested and stops the python commit if formatting is bad. then it runs black and fixes the formatting, resulting in a new git change to add/commit again

---------

Co-authored-by: Christopher Charbonneau Wells <10456740+cdubz@users.noreply.github.com>
barakplasma added a commit to barakplasma/babybuddy that referenced this issue Sep 30, 2023
* feat: weight percentiles report
babybuddy#512

* fix: formatting on weight percentile graph to extend out only 1 day more than the last weigh in date
babybuddy#708 (comment)

* feat: pre-commit lint with black hook
tested and stops the python commit if formatting is bad. then it runs black and fixes the formatting, resulting in a new git change to add/commit again

---------

Co-authored-by: Christopher Charbonneau Wells <10456740+cdubz@users.noreply.github.com>
@fs1
Copy link

fs1 commented Oct 9, 2023

This is really awesome! Thank you very much. Maybe you can also add https://www.who.int/tools/child-growth-standards/standards/length-height-for-age in one of the next releases? And maybe we should give somewhere (in the report itself?) a note that this chart will only work, if you document in kg (until now, I used gram).

@cdubz
Copy link
Member

cdubz commented Oct 9, 2023

@fs1 should be doable -- could you make a new issue with this request so we can track it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants