feat: Weight percentiles report #512 #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
barakplasma
commented
Sep 20, 2023
•
barakplasma
commented
- closes Feature Request: who comparative data in weight chart #512
- instead of adding the sex of the child to the DB model, or adding units to the weight report, I added new links to specific reports for boys and girls
- also bumps plotly versions
- adds quality of developer experience changes to the devcontainer / codespace extensions
- adds pre-commit black formatting / linting hook for devenv users
barakplasma
force-pushed
the
weight-percentiles-in-weight-graph
branch
from
fe5df7b
to
4535f84
Compare
barakplasma
changed the title
barakplasma
force-pushed
the
weight-percentiles-in-weight-graph
branch
3 times, most recently
from
af1d179
to
0221ae4
Compare
cdubz
previously requested changes
Sep 21, 2023
There was a problem hiding this comment.
When I open the PR in codspaces the .devcontainer.json file has modifications after everything boots up --
@cdubz ➜ /workspaces/babybuddy (weight-percentiles-in-weight-graph ✗) $ git diff .devcontainer.json
diff --git a/.devcontainer.json b/.devcontainer.json
index 75877d8..7110e18 100644
--- a/.devcontainer.json
+++ b/.devcontainer.json
@@ -4,7 +4,8 @@
"extensions": [
"bbenoist.Nix",
"ms-python.python",
- "batisteo.vscode-django"
+ "batisteo.vscode-django",
+ "ms-python.black-formatter"
]
}
},
barakplasma
force-pushed
the
weight-percentiles-in-weight-graph
branch
from
0221ae4
to
32c6c86
Compare
barakplasma
added a commit
to barakplasma/babybuddy
that referenced
this pull request
Sep 21, 2023
…ore than the last weigh in date babybuddy#708 (comment)
fixed as well; and I added a default formatting option for black within vscode / devcontainer / codespaces |
…ore than the last weigh in date babybuddy#708 (comment)
barakplasma
force-pushed
the
weight-percentiles-in-weight-graph
branch
from
1e8834c
to
21ed62d
Compare
tested and stops the python commit if formatting is bad. then it runs black and fixes the formatting, resulting in a new git change to add/commit again
cdubz
approved these changes
Sep 27, 2023
cdubz
added
the
enhancement
barakplasma
added a commit
to barakplasma/babybuddy
that referenced
this pull request
Sep 30, 2023
* feat: weight percentiles report babybuddy#512 * fix: formatting on weight percentile graph to extend out only 1 day more than the last weigh in date babybuddy#708 (comment) * feat: pre-commit lint with black hook tested and stops the python commit if formatting is bad. then it runs black and fixes the formatting, resulting in a new git change to add/commit again --------- Co-authored-by: Christopher Charbonneau Wells <10456740+cdubz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.