Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: update dashboard DC graph to include "both" #699

Closed
seanhagen opened this issue Aug 8, 2023 · 2 comments
Closed

Feature request: update dashboard DC graph to include "both" #699

seanhagen opened this issue Aug 8, 2023 · 2 comments
Labels
enhancement Feature requests or improvements to existing functionality good first issue Good candidates for simple work for first time contributors

Comments

@seanhagen
Copy link

image

It's hard to tell how many diaper changes actually happened when the graph shows wet and solid separately. Could the graph be updated to have a third color for changes that are both?

If I'm just not reading the graph properly then that's fine, it's just tricky to tell how many total changes there have been in a day from this graph.

@cdubz
Copy link
Member

cdubz commented Aug 9, 2023

Hm yeah I have thought about this in the past and not been sure exactly what direction to take. My take is that the important thing to show here is how many times the child peed and pooped in a given day not necessarily how many diaper changes took place.

Maybe adding a bit of textual metadata here would be useful? E.g show the label as “today (10 changes)” or have a secondary header with the number changes.

@cdubz cdubz added enhancement Feature requests or improvements to existing functionality good first issue Good candidates for simple work for first time contributors labels Sep 27, 2023
josevh added a commit to josevh/babybuddy that referenced this issue Dec 6, 2023
@josevh
Copy link
Contributor

josevh commented Dec 6, 2023

My use-case for this was in guess-timating how many diapers I'm going through daily when deciding whether or not to purchase more of the current size. It might just be a first-time-parent worry though 😅

josevh added a commit to josevh/babybuddy that referenced this issue Dec 6, 2023
josevh added a commit to josevh/babybuddy that referenced this issue Dec 6, 2023
josevh added a commit to josevh/babybuddy that referenced this issue Dec 8, 2023
@cdubz cdubz closed this as completed in 3131aeb Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements to existing functionality good first issue Good candidates for simple work for first time contributors
Projects
None yet
Development

No branches or pull requests

3 participants