New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #699, add diaper change count to card stats #737
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevh
force-pushed
the
diaperchange-change-count
branch
2 times, most recently
from
December 6, 2023 20:07
d4f5816
to
b853f6e
Compare
made a draft while I poke at tests |
josevh
force-pushed
the
diaperchange-change-count
branch
2 times, most recently
from
December 7, 2023 23:45
1936452
to
e1253c5
Compare
Seeing some errors and failures in the tests (run with Python 3.10.12). They appear unrelated. Run result: https://pastebin.com/m68hAESf |
Hm that seems like an odd collection of fails. Will try to take a look at the base tests soon. |
josevh
force-pushed
the
diaperchange-change-count
branch
from
December 8, 2023 22:19
e1253c5
to
9b14fc8
Compare
cdubz
added
the
enhancement
Feature requests or improvements to existing functionality
label
Dec 17, 2023
Looks good -- thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #699, updated the diaper change card stats to indicate how many diaper changes took place.
I implemented the solution suggested in the issue and added
(x changes)
after the day label. Please advise if it is confusing or if a better alternative is preferred. I also haven't worked with Django translations in a while, please let me know if there are additional changes required on that end.Screenshot