Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: devenv.sh for a reproducible developer environment (built on nix) #707

Merged
merged 5 commits into from Sep 19, 2023
Merged

feat: devenv.sh for a reproducible developer environment (built on nix) #707

merged 5 commits into from Sep 19, 2023

Conversation

barakplasma
Copy link
Contributor

my version of PR #549
uses devenv.sh for a reproducible developer environment (built on nix).

@coveralls
Copy link

coveralls commented Sep 17, 2023 •
edited

Coverage Status

coverage: 99.158% (-0.02%) from 99.176% when pulling 9c5337c on barakplasma:devenv into b5163c2 on babybuddy:master.

@cdubz
Copy link
Member

cdubz commented Sep 17, 2023 •
edited

Interesting. Thanks for sharing. Would this be an alternative to #549 ?

@barakplasma
Copy link
Contributor Author

barakplasma commented Sep 17, 2023 •
edited

Yes, would be an alternative to #549 .

Also enables GitHub codespaces I think, as an alternative to gitpod Github codespaces already works without this PR ,
since python/pipenv and node/nvm are already included. Just need to npm i and pipenv install. What my PR does is make the codespace not require the user to run npm i and pipenv install themselves.

@barakplasma barakplasma marked this pull request as ready for review September 17, 2023 09:13
@barakplasma barakplasma mentioned this pull request Sep 17, 2023
Closed
cdubz
cdubz requested changes Sep 17, 2023
View reviewed changes
Copy link
Member

@cdubz cdubz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really wonderful! And so easy.

Before merging I have a few questions posted via review... and maybe some small changes needed.

Thanks, again, for this work!

devenv.lock Show resolved Hide resolved
.envrc Show resolved Hide resolved
README.md Show resolved Hide resolved
docs/contributing/development-environment.md Show resolved Hide resolved
cdubz
cdubz approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@cdubz cdubz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok lets give this a try. I think we may want to tweak things as we go but this seems like a good foundation. Thanks 👍

@cdubz cdubz merged commit b8b0f7f into babybuddy:master Sep 19, 2023
15 checks passed
@barakplasma barakplasma deleted the devenv branch September 20, 2023 04:49
@barakplasma barakplasma mentioned this pull request Sep 27, 2023
Closed
@cdubz cdubz added this to the 2.1.0 milestone Sep 27, 2023
@cdubz cdubz added the task Specific non-feature things to do that don't require debugging label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdubz cdubz cdubz approved these changes

Assignees
No one assigned
Labels
task Specific non-feature things to do that don't require debugging
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@barakplasma @coveralls @cdubz