New statistic graphs: Diaper change intervals & feeding intervals

[myxor]

New statistic graphs: Diaper change intervals & feeding intervals

[coveralls]

Coverage decreased (-0.01%) to 98.333% when pulling 1ceb076 on myxor:statistics_diaper_change_intervals into 81ecff0 on babybuddy:master.

[myxor]

Feeding intervals statistics works pretty good but there is an issue with the Diaper change intervals statistics as the entries is "left-aligned". Means the graph starts on the left but the entries do not match the date-value on the x-axis.

Any help to fix this is much appreciated.

[cdubz]

@myxor are you still planning to move this PR forward?

[myxor]

@cdubz right now i am not planning. I didn't found a solution for issue described in my previous comment yet and therefore i stopped working on this.

Any help would me very much appreciated.

[garyglatfelter]

@myxor I think I understand the problem. I think it occurs because the interval lists (intervals, intervals_solid, intervals_wet) will always be length of one shorter than the changes list. One approach might be to simply not pass the first item of changes when providing the x values to be plotted.

In reports/graphs/diaperchange_intervals.py:
change
x=list(changes.values_list("time", flat=True))
to be
x=list(changes.values_list("time", flat=True))[1:]

I believe this statement occurs on line 40, line 49, and line 58. Please try that and let me know if that helps.

[barakplasma]

I handled the merge changes and @garyglatfelter 's suggestion in https://github.com/barakplasma/babybuddy/tree/continue-pr-444 as a way of testing my PR #707

[cdubz]

Nice! Looks like this can also be reviewed in Codespaces now. After we merge #707 I'll take a look at this.

[cdubz]

Ok this branch seems out of whack after some bad changes in the last rebase. Not sure how to proceed with it 🤔

[barakplasma]

I can open a new PR with all the git changes sorted out. I still want to provide credit to @myxor for doing the majority of the contribution, but unless they merge in my change / do it themselves... I think it will be a co-author credit?

[cdubz]

@barakplasma OK -- and actually you could open it from your branch from @myxor's and they'd still get the commit credits, right?

[cdubz]

Changes moved to #710.