Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: statistics on diaper change intervals #710

Merged
merged 2 commits into from Sep 30, 2023
Merged

feat: statistics on diaper change intervals #710

merged 2 commits into from Sep 30, 2023

Conversation

barakplasma
Copy link
Contributor

Continuation of #444 but with the git history sorted out.
Includes the fix from @garyglatfelter for graph starting from left axis

@myxor @barakplasma
New statistic graph: Diaper change intervals
d39ba23 
Fix formatting

Fix comment

Remove debug

Remove debug

Change naming of variable

Add new statistics graph: Feeding intervals

Fix naming

Add simple HTTP status code tests for new graphs

Remove number of feedings from graph

Remove obsolete yaxis2

Fix calculation of intervals and change scale to hours instead of minutes
@barakplasma barakplasma force-pushed the statistics_diaper_change_intervals branch 3 times, most recently from 8441fbf to 1f8d633 Compare September 30, 2023 05:50
@coveralls
Copy link

coveralls commented Sep 30, 2023 •
edited

Coverage Status

coverage: 98.958% (-0.02%) from 98.977% when pulling 9189571 on barakplasma:statistics_diaper_change_intervals into 8d8006a on babybuddy:master.

@barakplasma barakplasma force-pushed the statistics_diaper_change_intervals branch 2 times, most recently from c266905 to f639f67 Compare September 30, 2023 06:20
@barakplasma barakplasma force-pushed the statistics_diaper_change_intervals branch from f639f67 to 9189571 Compare September 30, 2023 06:39
@barakplasma barakplasma marked this pull request as ready for review September 30, 2023 06:57
cdubz
cdubz approved these changes Sep 30, 2023
View reviewed changes
Copy link
Member

@cdubz cdubz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- thanks for getting this fixed up!

@cdubz cdubz added the enhancement Feature requests or improvements to existing functionality label Sep 30, 2023
@cdubz cdubz added this to the 2.1.0 milestone Sep 30, 2023
@cdubz cdubz merged commit 1ebe5a5 into babybuddy:master Sep 30, 2023
17 checks passed
@cdubz cdubz mentioned this pull request Sep 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdubz cdubz cdubz approved these changes

Assignees
No one assigned
Labels
enhancement Feature requests or improvements to existing functionality
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@barakplasma @coveralls @cdubz @myxor