Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth pages #5

Merged
merged 4 commits into from
Sep 1, 2022
Merged

Auth pages #5

merged 4 commits into from
Sep 1, 2022

Conversation

rkkmkkfx
Copy link
Collaborator

@rkkmkkfx rkkmkkfx commented Sep 1, 2022

  • страницы sign-in/sign-up без бизнес-логики

* new pages
* Input component
* react-hook-form package
* default values
* signup form styles
* signup form heading

export type InputProps = OwnProps & Omit<InputHTMLAttributes<HTMLInputElement>, 'pattern'>;

const Input = forwardRef<HTMLInputElement, InputProps>((props, ref) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно деструктуризацию сразу в аргументах сделать
код компактнее будет

@@ -0,0 +1,4 @@
import Input from './Input';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно написать вот так

Suggested change
import Input from './Input';
export { default } from './Input';

Copy link
Collaborator Author

@rkkmkkfx rkkmkkfx Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, всегда так делал, но eslint после какого-то обновления начал кровить на такие реэкспорты, тут вот решают проблему

@rkkmkkfx rkkmkkfx merged commit aadeba3 into main Sep 1, 2022
@rkkmkkfx rkkmkkfx deleted the auth-pages branch September 1, 2022 13:43
@rkkmkkfx
Copy link
Collaborator Author

rkkmkkfx commented Sep 1, 2022

@rkkmkkfx rkkmkkfx self-assigned this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants