Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfStones PR for bbntest-4 #165

Closed
wants to merge 1 commit into from
Closed

InfStones PR for bbntest-4 #165

wants to merge 1 commit into from

Conversation

adam-infstones
Copy link
Contributor

InfStones PR for bbn-test-4. Please review.

@RafilxTenfen
Copy link
Contributor

Hey @adam-infstones can you verify this?
[btc-staker] finality provider pk in tx 75ef424249a4b734ed730468387b33dfa596e1912dfa8b6ea4f36af488b2bcf0 do not match with flag 3b88d9cf5f52ab6ae4b5b25d6a8b3b779a2baa4bd5204f5a78ecd95e878361ea
Seems like a diff fp pk was used

@adam-infstones
Copy link
Contributor Author

Working to verify now

@adam-infstones
Copy link
Contributor Author

adam-infstones commented May 22, 2024

Here I created the transaction with this finality provider pk shown here.

./stakercli transaction create-phase1-staking-transaction --staker-pk 71e47cf1ad8e58e6182524369c9842d1be178f47912b92b8c40dfbb006afed32 --staking-amount 10000000 --staking-time 52560 --magic-bytes 62627434 --finality-provider-pk 75ef424249a4b734ed730468387b33dfa596e1912dfa8b6ea4f36af488b2bcf0 --covenant-quorum 1 --covenant-committee-pks 50929b74c1a04954b78b4b6035e97a5e078a5a0f28ec96d547bfee9ace803ac0 --network signet
{
"staking_tx_hex": "02000000000280969800000000002251202c48b5d242b8b359db0fbcb605d3e7dab191998f0a25511c1d9851e81cd8c59f0000000000000000496a47626274340071e47cf1ad8e58e6182524369c9842d1be178f47912b92b8c40dfbb006afed3275ef424249a4b734ed730468387b33dfa596e1912dfa8b6ea4f36af488b2bcf0cd5000000000"
}

Here we can see after running all the other transaction commands, this was verified locally.

./eotsd verify-schnorr-sig /home/ubuntu/sample.txt --btc-pk 3b88d9cf5f52ab6ae4b5b25d6a8b3b779a2baa4bd5204f5a78ecd95e878361ea --signature 1db9c6e7e3b3debfa8e9e5bef425e2968b1f7f72fee811be51a5c6d7951b5c69b17447ac9145789a25b186ab958a801fc3ba583b77a8236444843f0eb446d58b
Verification is successful!

If I screwed this up and need to rerun, please let me know.

@RafilxTenfen
Copy link
Contributor

RafilxTenfen commented May 22, 2024

./stakercli transaction create-phase1-staking-transaction --staker-pk 71e47cf1ad8e58e6182524369c9842d1be178f47912b92b8c40dfbb006afed32 --staking-amount 10000000 --staking-time 52560 --magic-bytes 62627434 --finality-provider-pk 75ef424249a4b734ed730468387b33dfa596e1912dfa8b6ea4f36af488b2bcf0 --covenant-quorum 1 --covenant-committee-pks 50929b74c1a04954b78b4b6035e97a5e078a5a0f28ec96d547bfee9ace803ac0 --network signet

your --finality-provider-pk is not the same as btc_pk inside your json file https://github.com/babylonchain/networks/pull/165/files#diff-399fbf6615a841e3364b0edf69bbb05561dabc17d74b3047cfcf2f130d2016f2R9
as it should be

The signature ci/circleci: verify-sig is probably failing because the file you submit here is not actually the same as you used to sign, the file needs to be exactly the same not just the content

@adam-infstones
Copy link
Contributor Author

adam-infstones commented May 22, 2024

Okay, I think I am just going to have to run through the process and submit a new PR. I will close this one out and work to get through the process and new PR submitted by end of day. Apologies for the confusion.

@RafilxTenfen
Copy link
Contributor

Okay, I think I am just going to have to run through the process and submit a new PR. I will close this one out and work to get through the process and new PR submitted by end of day. Apologies for the confusion.

All good, you are probably going to need to ask for funds again @filippos47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants