Skip to content

Commit

Permalink
Add myself to the team (#270)
Browse files Browse the repository at this point in the history
* Reorder team members to follow alphabetical order

* Add Davide to the team

* Add note on how to add members to the team in the correct way

When doing it I was going to edit `README.md` manually, until I noticed the script.
This will avoid new members making this mistake, as it specifies how to do it.

* Update Cookbook/Technical-Documents/NewHiresCheckList.md

Improve message specifying how to update the team

Co-Authored-By: Daniel Spindelbauer <dan.spindelbauer@babylonhealth.com>
  • Loading branch information
2 people authored and ilyapuchka committed Nov 5, 2019
1 parent 10b1f4a commit 1ab2483
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
1 change: 1 addition & 0 deletions Cookbook/Technical-Documents/NewHiresCheckList.md
Expand Up @@ -98,6 +98,7 @@ shell script. Here's how to get the iOS project up and running:
1. It can be useful to create a command line alias for `pod` to `bundle exec pod` so that you are guaranteed to always be running the correct version of CocoaPods.

1. Add yourself to the team list in the [playbook](https://github.com/babylonhealth/ios-playbook) by making your first PR 😉
You can do this by editing `scripts/squads.yml` and then running `ruby scripts/squads.rb` which will update the list

1. Add shared `iOS Developers` calendar to your calendar on Outlook

Expand Down
3 changes: 2 additions & 1 deletion README.md
Expand Up @@ -81,9 +81,10 @@ The rest of the iOS Engineers work in the following squads:
<tr><td>Daniel Spindelbauer</td><td><a href='https://github.com/sdaniel55'>@sdaniel55</a></td><td><a href='https://twitter.com/sdaniel55'>@sdaniel55</a></td></tr>
<tr><td>Diego Petrucci</td><td><a href='https://github.com/diegopetrucci'>@diegopetrucci</a></td><td><a href='https://twitter.com/diegopetrucci'>@diegopetrucci</a></td></tr>
<tr><td>Joshua Simmons</td><td><a href='https://github.com/j531'>@j531</a></td><td></td></tr>
<tr><td rowspan='2' valign='top'><strong>Prescriptions</strong><br/>Prescriptions functionality.</td>
<tr><td rowspan='3' valign='top'><strong>Prescriptions</strong><br/>Prescriptions functionality.</td>
<td>Adam Borek</td><td><a href='https://github.com/TheAdamBorek'>@TheAdamBorek</a></td><td><a href='https://twitter.com/TheAdamBorek'>@TheAdamBorek</a></td></tr>
<tr><td>Konrad Muchowicz</td><td><a href='https://github.com/konrad-em'>@konrad-em</a></td><td></td></tr>
<tr><td>Davide De Franceschi</td><td><a href='https://github.com/defrenz'>@defrenz</a></td><td><a href='https://twitter.com/defrenz'>@defrenz</a></td></tr>
<tr><td rowspan='1' valign='top'><strong>Partnerships</strong><br/>Updating and maintaining the Telus app.</td>
<td>Simon Cass</td><td><a href='https://github.com/scass91'>@scass91</a></td><td><a href='https://twitter.com/codercass'>@codercass</a></td></tr>
<tr><td rowspan='1' valign='top'><strong>SDK</strong><br/>Develop and maintain the SDK frameworks.</td>
Expand Down
11 changes: 8 additions & 3 deletions scripts/squads.yml
Expand Up @@ -30,9 +30,6 @@ team:
- &Chesley
name: Chesley Stephens
github: cstephens-babylon
- &Tyler
name: Tyler Hargett
github: thargett-babylon
- &Chitra
name: Chitra Kotwani
github: chitrakotwani
Expand All @@ -51,6 +48,10 @@ team:
name: David Rodrigues
github: dmcrodrigues
twitter: dmcrodrigues
- &Davide
name: Davide De Franceschi
github: defrenz
twitter: defrenz
- &Diego
name: Diego Petrucci
github: diegopetrucci
Expand Down Expand Up @@ -114,6 +115,9 @@ team:
name: Simon Cass
github: scass91
twitter: codercass
- &Tyler
name: Tyler Hargett
github: thargett-babylon
- &Viorel
name: Viorel Mihalache
github: viorel15
Expand Down Expand Up @@ -199,6 +203,7 @@ squads:
members:
- *Adam
- *Konrad
- *Davide
- name: Partnerships
desc: Updating and maintaining the Telus app.
members:
Expand Down

0 comments on commit 1ab2483

Please sign in to comment.