Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a panic in the wasm executor when entrypoint is not known #3779

Merged
merged 2 commits into from
Apr 12, 2024

Commits on Apr 11, 2024

  1. Fixes a panic in the wasm executor when entrypoint is not known

    Currently we try to reference the `ExportedFunction` which is documented
    as returning nil when the name is not found. Instead it returns a
    non-nil object with an inner nil field which will cause a panic when
    `Call`-ed.
    
    This commit instead looks up the function before referencing it to
    ensure it exists, returning an error early if not. This allows us to
    remove the call to recover which was handling the panic() for us.
    rossjones committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    3c8736e View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Configuration menu
    Copy the full SHA
    94b9c8e View commit details
    Browse the repository at this point in the history