Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong y label corrected #709

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Wrong y label corrected #709

merged 6 commits into from
Jun 3, 2024

Conversation

MadniAbdulWahab
Copy link
Contributor

@MadniAbdulWahab MadniAbdulWahab commented May 13, 2024 •
edited by dominikbach
Loading

Fixes #570.

Changes proposed in this pull request:

  • ylabel added in the loop where channel is being changed

@MadniAbdulWahab MadniAbdulWahab linked an issue May 13, 2024 that may be closed by this pull request
pspm_data_editor displays wrong y label #570
Closed
@teddychao teddychao self-assigned this May 28, 2024
@teddychao teddychao added the In Progress Currently being worked on label May 28, 2024
@teddychao teddychao marked this pull request as draft May 28, 2024 13:45
@teddychao
Copy link
Contributor

This is now fixed
image
image

@teddychao
Copy link
Contributor

Hi @MadniAbdulWahab
For code organisation purpose, I moved your update to the function AddPlot, because the update is targeting the wrong code of y label handling in AddPlot. Hope you do not mind.
Thanks

@teddychao teddychao marked this pull request as ready for review June 3, 2024 14:31
@teddychao teddychao added Completed & Waiting for Review Completed and waiting for review and removed In Progress Currently being worked on labels Jun 3, 2024
@dominikbach dominikbach added Approved The pull request has been approved and can be checked and then merged. and removed Completed & Waiting for Review Completed and waiting for review labels Jun 3, 2024
@dominikbach dominikbach merged commit c185139 into develop Jun 3, 2024
1 check passed
@dominikbach dominikbach deleted the 570-wrong-y-label branch June 3, 2024 15:50
@teddychao teddychao removed the Approved The pull request has been approved and can be checked and then merged. label Jun 24, 2024
@teddychao teddychao added this to the v7.0 milestone Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikbach dominikbach dominikbach approved these changes

Assignees

@teddychao teddychao

@MadniAbdulWahab MadniAbdulWahab

Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.

pspm_data_editor displays wrong y label
3 participants
@MadniAbdulWahab @teddychao @dominikbach