Fix #30, error using fetch when collection's url is a method

backbone-paginator · Jan 18, 2013 · fe5c3af · fe5c3af
1 parent 3a06f51
commit fe5c3af
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/backbone-pageable.js b/lib/backbone-pageable.js
@@ -992,6 +992,7 @@
 
       // dedup query params
       var url = options.url || this.url || '';
+      url = typeof url == 'function' ? url() : url
       var qsi = url.indexOf('?');
       if (qsi != -1) {
         _extend(data, queryStringToParams(url.slice(qsi + 1)));

diff --git a/test/collection.js b/test/collection.js
@@ -396,6 +396,20 @@ $(document).ready(function() {
     equal(this.syncArgs.options.parse, false);
   });
 
+  test("ensure fetch works if a collection's url is a method", 4, function() {
+    var collection = new Backbone.PageableCollection;
+    collection.url = function() {
+        return '/test';
+    }
+    collection.fetch();
+    equal(this.syncArgs.method, 'read');
+    equal(this.syncArgs.model, collection);
+    equal(this.syncArgs.options.parse, true);
+
+    collection.fetch({parse: false});
+    equal(this.syncArgs.options.parse, false);
+  });
+
   test("ensure fetch only parses once", 1, function() {
     var collection = new Backbone.PageableCollection;
     var counter = 0;