This repository has been archived by the owner on May 17, 2018. It is now read-only.
Urldecode queryParams, pass parsed data to queryParams functions #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have test cases for these? And if you don't mind, can you make a pull request from a separate branch for each issue please? The later is not required tho if it's too much trouble. |
|
Unfortunately no tests yet - these are just some small - but blocking - issues I wanted to fix. I'm sorry, I don't have the time atm. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having trouble actually using the next link (returned as a Header from my app). Having access to the parsed qs data from the given url and a queryParams function solved this elegantly and in a flexible manner. I believe the qs data should be url decoded, not just the key.