-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to put site in maintenance mode when backing up #117
Comments
The PR is ready for testing if anyone could. Testing is a bit tricky, as you need to find one process that takes a long time so that you can see that the site is indeed put in maintenance mode. For example, testing this with a real site with lots of nodes and fields. If you are thinking that "Backup my entire site" will provide an opportunity to test this (since it takes a long time), unfortunately it won't. There seems to be a different bug both in D7 and Backdrop, where the site is only put on maintenance during the first process (DB backup) and not the second (compressing the files), which takes a long time. This should be addressed on a different issue. So, this is the behavior both when backing up and restoring:
If the site was in maintenance mode before backing up or restoring, the site will be left in maintenance mode when completing those. |
Wow, I couldn't think of a way to test that. |
Thanks, @indigoxela. Did you have a chance to test? @cellear, would you have the time to test this too? |
Unfortunately no. The PR makes sense, but I'm not able to test. |
I have the time, and I'm planning to catch up on backlog this weekend, but I too have not thought of a way to test this until the other bug mentioned (that it doesn't stay in maintenance mode during compression) is also addressed. |
I am also unable to add any labels to the issue. |
Like others have said the code looks good. I'd say this is RTBC x 1. |
Issue #117. Correctly handle maintenance mode on and off
When BM was ported, the lines
variable_get('maintenance_mode')
andvariable_set('maintenance_mode', 1)
were ported as a config setting withinbackup_migrate.settings
(!!!). This setting, of course, doesn't work. The result is that BM is unable to put the site in maintenance mode when backing up.The text was updated successfully, but these errors were encountered: