New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to inline buttons #24

Closed
BWPanda opened this Issue May 30, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@BWPanda

BWPanda commented May 30, 2017

It looks like ShareThis has upgraded their buttons, and they've got a migration guide from their legacy buttons here: https://www.sharethis.com/support/installation/migrate-from-sharethis-legacy-buttons-to-inline-buttons/

Can we update this module to support the new buttons?

@jenlampton

This comment has been minimized.

Member

jenlampton commented Aug 5, 2017

Yes, thanks for the link! :)

@jenlampton

This comment has been minimized.

Member

jenlampton commented Oct 7, 2017

I've created a 1.x-1.3.x branch for the new inline buttons. This version of the module is much simpler, so I cleaned up a lot of the cruft in the process.

@jenlampton jenlampton closed this Oct 7, 2017

@helenasue

This comment has been minimized.

helenasue commented Oct 10, 2017

Chiming in: fwiw, the new inline ShareThis button aren't accessible AT ALL. They have zero keyboard or screen reader accessibility. I've reached out to them and offered to help them fix it, but they have a long history of downplaying a11y, so it might not help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment