Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style.css #7

Merged
merged 1 commit into from
Jan 22, 2015
Merged

Update style.css #7

merged 1 commit into from
Jan 22, 2015

Conversation

docwilmot
Copy link
Contributor

As requested.

As requested.
margin-bottom: 2em;
}

blockquote.d7diff {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @docwilmot, this looks good to me. Could we make this a bit more generic a class so we could use it in the future for Backdrop 1.x to 2.x changes? How about just "change" or "diff"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its best to keep it so we can style D7 differences differently from other differnces, if you understand what I mean. In time we could create a .bddiff callout block, give it a red background so its obvious etc. Please feel free to change from #eee to something more attention-grabbing #FFFFEA?

@docwilmot
Copy link
Contributor Author

Reminder.

@quicksketch
Copy link
Member

Hm, I'm still not hot on the class name. We can revisit this later I suppose. I'll merge and pull this into the live API site.

quicksketch added a commit that referenced this pull request Jan 22, 2015
@quicksketch quicksketch merged commit ceb865e into backdrop-ops:master Jan 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants