Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bartik: search block search button is considerably smaller than search box and vertically aligned to the top. #1614

Closed
klonos opened this issue Feb 14, 2016 · 4 comments
Closed

Bartik: search block search button is considerably smaller than search box and vertically aligned to the top. #1614

klonos opened this issue Feb 14, 2016 · 4 comments
Labels
design status - fixed status - has pull request type - bug report
Milestone
1.13.4

Comments

@klonos
Copy link
Member

klonos commented Feb 14, 2016 •
edited

backdrop-bartik_theme-search_button_small

PR by @klonos: backdrop/backdrop#2854
@ghost
Copy link

ghost commented Sep 6, 2019

@klonos Is this still the case, or is it fixed now?

klonos added a commit to klonos/backdrop that referenced this issue Sep 7, 2019
@klonos
Issue backdrop#1614: Bartik: Fix search block search button height.
d718c52 
backdrop/backdrop-issues#1614
@klonos klonos mentioned this issue Sep 7, 2019
Merged
@klonos
Copy link
Member Author

klonos commented Sep 7, 2019 •
edited

At some point we must have increased the height of the button, but it seems to still be off by 1px:

Screen Shot 2019-09-07 at 3 03 40 am

...its height is currently 25px, but it aligns perfectly if changed to 26px:

Screen Shot 2019-09-07 at 3 19 43 am

PR up for review: backdrop/backdrop#2854

@stpaultim
Copy link
Member

Looks good to me.

backdrop-ci referenced this issue in backdrop/backdrop Sep 16, 2019
@klonos @quicksketch
Issue #1614: Bartik: Fix search block search button height.
3c075db 
By @klonos and @stpaultim.
backdrop-ci referenced this issue in backdrop/backdrop Sep 16, 2019
@klonos @quicksketch
Issue #1614: Bartik: Fix search block search button height.
e28c7c7 
By @klonos and @stpaultim.
@quicksketch
Copy link
Member

Thanks folks! Merged backdrop/backdrop#2854 into 1.x and 1.13.x.

@quicksketch quicksketch added this to the 1.13.4 milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design status - fixed status - has pull request type - bug report
Projects
None yet
Milestone
1.13.4
Development

No branches or pull requests
3 participants
@quicksketch @klonos @stpaultim