-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace/update toolbar with a responsive/touch-friendly version (Replace with Admin Menu) #189
Comments
I would agree with this approach. I think that admin_menu works really well. The search functionality could still use some work. I think that people will always assume it works for all pieces of content from admin to their actual site. |
I agree too. The first thing I did with every drupal site was to disable toolbar and install admin_menu. |
Of the potential starting points, I think the Admin Menu module itself is the right module to start with. The existing options:
Of these, admin menu is definitely the easiest module to adapt to our purposes, so I've been working on trimming it down and adding the critical functionality (touch support, responsive) that we require. |
Okay, I filed backdrop/backdrop#207 to get this rolling. Sorry I've been working on this the last few days without posting an update. It's hard to see from the pull request how much changed from the D7 version, so I made a diff of the overall changes as well: Here are the changes summarized:
I'll work on testing this functionality over the next couple of days, but I'd also love any feedback. Design-wise, I largely avoided anything new (i.e. there's no hamburger icon yet) and I didn't create CSS for the a "hamburger mobile mode", since that will also require some styling. At this point it's basically just a touch- (but not necessarily mobile-) friendly version of Admin Menu. |
Hi @quicksketch . I just downloaded and tried installing and am getting this error on the verify requirements page.
The dependency needs to be removed from /profiles/standard/standard.info Regards |
Excellent @quicksketch.It works really well and looks good. I love how the menu search works, showing you where the link is in the admin menu. It will help people to learn where things are. Finally a decent toolbar. It needs to be enabled automatically when Backport is installed. I know you know this. :-) Kudos and thanks for Backdrop. It is going to be awesome! Regards |
Ah! Of course, I actually forgot that part. I didn't fully search/replace for "toolbar". I'll update the PR. |
Looks great! Glad you based it on admin menu |
I've update the PR to include Admin Menu on install (sorry about that!) as well as checked to make sure Toolbar wasn't referenced anywhere else in the code. I also renamed the "Drupal.admin" behaviors to "Drupal.adminMenu", since I don't think we should be so presumptuous with our namespacing. Lastly I fixed the minor padding issues you can see in the last 3 screenshots above when the search menu is open, which only happened in Chrome. |
I updated the title in this issue to reflect what's going on in here. We'll still need a followup to make it "mobile friendly", since this still isn't going to be ideal on a phone. On a table, the dropdown menus actually work pretty well. |
You would have to be desperate to admin a Drupal/backdrop site from a phone, wouldn't you? |
Yeah, maybe where we live. In a lot of countries phones are really the primary devices, but I'm not sure if that audience really overlaps strongly with Backdrop's administrative users. In any case, long term it'd be good to get a better menu solution for small screens. One of my friends pointed out https://www.airbnb.com/help has a great sliding navigation that can go infinitely levels deep. It looks great but only would allow deepest level items to be clicked on, which isn't currently the case with Admin Menu. Anyway, it's something to keep an eye on; though it's not something we need to address immediately. A week ago I updated the PR to support the upgrade path correctly. I think this is all ready to go, though it'll need more work in the future. It definitely beats the pants off of Toolbar module. |
I've merged in backdrop/backdrop#207. The door is open to further improvement of course. Search could be improved as well as better small-screen device support, but for most users this is a big win. Yay! |
Drupal 8 updated the Toolbar module so that it has a "mobile mode" which displays along the left-side of the screen. There is a D7 backport of this functionality at https://drupal.org/project/navbar.
The situation for Backdrop is slightly different. We've removed the Shortcut functionality from Backdrop in #76, which is the primary reason for Navbar being a menu of menus. Instead of a Navbar-like interface, I'd love to see Backdrop's toolbar take an approach that is closer to admin_menu. I'm hoping for something similar to this:
The text was updated successfully, but these errors were encountered: