[UX] Remove the "Add a" part from the hero and custom block titles.

[klonos]

...shouldn't this be either "Hero block" or pull whatever is in the Display title field for the hero block instead ("Welcome to Backdrop CMS" by default)?

---

PR by @klonos: backdrop/backdrop#1597

[klonos]

...other side-effect of this ("Add block" dialog):

[klonos]

I expect tests to fail (just wanted to file the PR in order to get the sandbox). I'll fix them.

[klonos]

Tests green! 😉

...just a quick question though. What is the logic with this part of the code? The way we have it now, it excludes any custom blocks from being selected as source for the Page title. Why?

[jenlampton]

I'm not sure it's a bug, but giving the Add block list some much-needed attention is definitely a UX improvement :)

See related issue: #2255 [UX] Decide when to add 'block' to the end of block admin titles, and do so consistently.

Also: #2254 [UX] Prefix all menu block admin labels with "Menu:"

[klonos]

I'm not sure it's a bug,...

This issue was initially filed because of the wrong UI text "Add a hero block" that appeared in the drop-down list of blocks making it seem as an action rather than an option (because of the "Add a" part). User confusion = UX bug in my head, but bug or task I don't care so long as it's fixed 😄

[klonos]

@jenlampton I did see and comment on those issues you filed. Thank you for those.

Do you have any idea about my question above with regards to the && $title !== 'Add a custom block' check in https://github.com/backdrop/backdrop/blob/1.x/core/modules/layout/layout.admin.inc#L1063 ?? It prevents users from setting a custom block as the source of the page title. Any particular reason we are doing that for?

[klonos]

...and also related: #2256

[quicksketch]

It prevents users from setting a custom block as the source of the page title. Any particular reason we are doing that for?

Perhaps it's just because the custom block lives only within the layout, there's little point in sharing it's title? I'm not sure about this myself, it does seem a little strange.

I think it might make more sense for us to use the $block->adminLabel() method here instead of $block_info['info'].

[klonos]

I think it might make more sense for us to use the $block->adminLabel() method here instead of $block_info['info'].

I'm not sure if you are referring to something that needs to be done in my PR @quicksketch or if you are referring to the way we render the "Block to copy" drop-down menu options and the missing entry for any custom blocks present in the current layout, which seems to me like a separate issue (that I would still like to solve). My current PR simply removes the "Add block" prefix from the labels of the hero and custom blocks, which is what this issue here is about.

[quicksketch]

Thanks @klonos, I've merged backdrop/backdrop#1597 into 1.x. As this causes a string change and 1.6.0 is right around the corner, I didn't merge this into 1.5.x.

[klonos]

@quicksketch we still did not address this concern of yours (because I didn't understand what you meant actually). Should I file a separate issue for that? Also, can you please elaborate a bit on what you meant?