Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTML5 number fields in Views #255

Closed
quicksketch opened this issue Jun 15, 2014 · 1 comment · Fixed by backdrop/backdrop#787
Closed

Use HTML5 number fields in Views #255

quicksketch opened this issue Jun 15, 2014 · 1 comment · Fixed by backdrop/backdrop#787

Comments

@quicksketch
Copy link
Member

This is a followup to backdrop/backdrop#247 and #200. We introduced HTML5 number and range elements, but there are a few places within Views that could leverage this functionality which were not included in the original PR.

Views includes a custom validation function for positive integers, views_element_validate_integer(). We should remove this entire function and any places it's used (number of table columns, results per page, etc) within Views. These places can be replaced with an HTML5 number field.

@quicksketch
Copy link
Member Author

This isn't a blocker for 1.0.0, so moving to 1.x-future. We can make this change at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant