Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] HTML5 for Backdrop #200

Closed
32 tasks done
jenlampton opened this issue Mar 16, 2014 · 2 comments
Closed
32 tasks done

[META] HTML5 for Backdrop #200

jenlampton opened this issue Mar 16, 2014 · 2 comments
Milestone

Comments

@jenlampton
Copy link
Member

We need to triple check that we have all the HTML5 hotness that's in Drupal 8.

Someone will need to review each issue mentioned in the following d.o issues and check the date the patch was committed to D8. If it was before our fork date (Feb 29th, 2012) then we have the change, and nothing else needs to be done. If it was committed after that date, however, then we'll need to include it here to be sure we get the changes.

General HTML5 changes

(http://drupalcode.org/project/drupal.git/commit/ae5cc6f8f40604987274799978e065bd5820d07b) | d.o
(http://drupalcode.org/project/drupal.git/commit/8fd2b4779ec83c3e44a8caac65300b96e3a52ab8) | d.o

Re-factor templates / theme functions to use HTML5 elements

Review this list

Themes

Form API support for new HTML5 elements

Review this list

RELATED ISSUES

@quicksketch
Copy link
Member

@clickbox filed a PR for the first issue (color elements): backdrop/backdrop#187

The PR looks like a great start, but unfortunately I think the PR won't work because it first depends on adding HTML5 color element, before we add an HTML5 color field. Additionally, this color field wasn't even committed to Drupal 8.

I think we may have linked to the wrong issue in this meta. We linked to https://drupal.org/node/1740438, but it should have been https://drupal.org/node/1445224. Doh! I've fixed the meta list in this issue to point to the right d.o issue.

That issue also gets a bit gnarly since it introduces a new PSR-0 class for "Color", and then it had several followups fixing problems. We might need to make a separate stand-alone issue here to discuss how we want to implement this in Backdrop.

@jenlampton jenlampton added this to the 1.0.0 milestone Nov 3, 2014
@quicksketch
Copy link
Member

Let's go ahead and close this issue out. For the 1.0.0 release, we are already where we want to be. I made a new issue for multiple file uploads (#440), which we can try to wrap up in the 1.1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants